Author mark.dickinson
Recipients facundobatista, jjconti, mark.dickinson, rhettinger, skrah
Date 2010-01-29.19:03:37
SpamBayes Score 2.28974e-06
Marked as misclassified No
Message-id <1264791819.87.0.845894831267.issue7633@psf.upfronthosting.co.za>
In-reply-to
Content
The updated patch looks good---thank you!  We're getting there... :)

I'm not sure about the extra 'Operand can be Decimal or int.' in the method docstrings;  this just looks like extra clutter to me.  Rather, I think it would be a surprise worthy of documentation if these methods *didn't* accept int or long;  since they now do (with your patch), I don't think it's really worth mentioning in the docstring.  And it's not quite accurate, either, since these methods should accepts longs as well as ints (and bools, and instances of other subclasses).

Would you be content to remove these from the docstrings?  Or do others monitoring this issue think they should stay?

The extra doctests and test_decimal tests are nice.
History
Date User Action Args
2010-01-29 19:03:40mark.dickinsonsetrecipients: + mark.dickinson, rhettinger, facundobatista, jjconti, skrah
2010-01-29 19:03:39mark.dickinsonsetmessageid: <1264791819.87.0.845894831267.issue7633@psf.upfronthosting.co.za>
2010-01-29 19:03:38mark.dickinsonlinkissue7633 messages
2010-01-29 19:03:37mark.dickinsoncreate