Message98507
A couple of comments about issue7092_syntax_imports_v3.diff too:
1) in test_copy you remove (k,v), but left the name 'k' even if now it represent the item and not the key;
2) in test_fractions you should probably use self.fail() instead of an assert;
3) on test_ftp you can use two separate lines and remove the ';';
4) in test_pyclbr there's one extra 'f' in the comment in assertHaskey;
5) in test_xml_etree_c you can either leave callable() and catch the warning or use isinstance(x, collections.Callable) instead (there are also a few more places where callable was used too). |
|
Date |
User |
Action |
Args |
2010-01-29 12:21:36 | ezio.melotti | set | recipients:
+ ezio.melotti, barry, rhettinger, exarkun, amaury.forgeotdarc, pitrou, benjamin.peterson, eric.araujo, brian.curtin, flox, esam |
2010-01-29 12:21:36 | ezio.melotti | set | messageid: <1264767696.33.0.591226516426.issue7092@psf.upfronthosting.co.za> |
2010-01-29 12:21:34 | ezio.melotti | link | issue7092 messages |
2010-01-29 12:21:34 | ezio.melotti | create | |
|