This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, barry, benjamin.peterson, brian.curtin, eric.araujo, esam, exarkun, ezio.melotti, flox, pitrou, rhettinger
Date 2010-01-29.00:34:21
SpamBayes Score 0.000350174
Marked as misclassified No
Message-id <>
Here is my review of issue7092_syntax_imports_v3.diff:

- please replace
      [tuple([arg[i] if i < len(arg) else None for arg in args])
       for i in range(max(map(len, args)))]
  by something more readable (nested for loops for example)

- why doesn't test_support.import_module('rfc822')
  specify deprecated=True? maybe the module can be imported normally...

-   replace self.assertTrue(key in obj) with assertIn()
-  replace self.assertTrue(key in h.environ)

- test could be identical to the one in py3k.
Date User Action Args
2010-01-29 00:34:23amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, barry, rhettinger, exarkun, pitrou, benjamin.peterson, ezio.melotti, eric.araujo, brian.curtin, flox, esam
2010-01-29 00:34:23amaury.forgeotdarcsetmessageid: <>
2010-01-29 00:34:21amaury.forgeotdarclinkissue7092 messages
2010-01-29 00:34:21amaury.forgeotdarccreate