Message98491
Here is my review of issue7092_syntax_imports_v3.diff:
- test_itertools.py: please replace
[tuple([arg[i] if i < len(arg) else None for arg in args])
for i in range(max(map(len, args)))]
by something more readable (nested for loops for example)
- test_mailbox.py: why doesn't test_support.import_module('rfc822')
specify deprecated=True? maybe the module can be imported normally...
- test_pyclbr.py: replace self.assertTrue(key in obj) with assertIn()
- test_wsgiref.py: replace self.assertTrue(key in h.environ)
- test_queue.py: test could be identical to the one in py3k. |
|
Date |
User |
Action |
Args |
2010-01-29 00:34:23 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, barry, rhettinger, exarkun, pitrou, benjamin.peterson, ezio.melotti, eric.araujo, brian.curtin, flox, esam |
2010-01-29 00:34:23 | amaury.forgeotdarc | set | messageid: <1264725263.27.0.745348912994.issue7092@psf.upfronthosting.co.za> |
2010-01-29 00:34:21 | amaury.forgeotdarc | link | issue7092 messages |
2010-01-29 00:34:21 | amaury.forgeotdarc | create | |
|