This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author amaury.forgeotdarc
Recipients Trundle, amaury.forgeotdarc, brett.cannon, flox, r.david.murray
Date 2010-01-28.18:28:12
SpamBayes Score 5.293522e-05
Marked as misclassified No
Message-id <>
This is slightly incorrect: if PyFile_FromFile fails for another reason (PyString_FromString(name) runs out of memory), the fp is not closed and the caller is right to call fclose().

IMO PyFile_FromFile() should be changed to consistently leave the fp opened when NULL is returned. But then, many usages of this function are incorrect, e.g in posixmodule.c :-(
Date User Action Args
2010-01-28 18:28:31amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, brett.cannon, r.david.murray, Trundle, flox
2010-01-28 18:28:29amaury.forgeotdarcsetmessageid: <>
2010-01-28 18:28:13amaury.forgeotdarclinkissue7732 messages
2010-01-28 18:28:12amaury.forgeotdarccreate