Message97671
Thanks for looking at the patch.
Attached is an updated version (again against py3k) which adds tests to Lib/test/test_peepholer.py, for both the new folding away of BUILD_SET, and for the pre-existing folding of BUILD_LIST (which didn't seem to have tests).
Hopefully these look good. One possible worry I had with them is with the string comparison against repr(various frozensets) for the disassembly of the bytecode: the new tests thus assume that the ordering of the repr of a frozenset is constant. Is this a reasonable assumption, or should the choice of test items be changed to ones with more robust ordering in their repr() string? |
|
Date |
User |
Action |
Args |
2010-01-12 22:59:45 | dmalcolm | set | recipients:
+ dmalcolm, rhettinger, pitrou, alex |
2010-01-12 22:59:45 | dmalcolm | set | messageid: <1263337185.91.0.0590724001482.issue6690@psf.upfronthosting.co.za> |
2010-01-12 22:59:44 | dmalcolm | link | issue6690 messages |
2010-01-12 22:59:43 | dmalcolm | create | |
|