Author dmalcolm
Recipients alex, dmalcolm, pitrou, rhettinger
Date 2010-01-12.19:57:17
SpamBayes Score 8.98046e-06
Marked as misclassified No
Message-id <1263326241.2.0.265928262441.issue6690@psf.upfronthosting.co.za>
In-reply-to
Content
Alex: good point - thanks!

Attaching updated version of the patch (again, against py3k, likewise, I'm somewhat new to this code, so I may have missed things)

With this:
>>> dis.dis(lambda o: o in {1,2,3})
  1           0 LOAD_FAST                0 (o) 
              3 LOAD_CONST               3 (frozenset({1, 2, 3})) 
              6 COMPARE_OP               6 (in) 
              9 RETURN_VALUE         
>>> dis.dis(lambda o: o in {1,2,3,3,2,1})
  1           0 LOAD_FAST                0 (o) 
              3 LOAD_CONST               3 (frozenset({1, 2, 3})) 
              6 COMPARE_OP               6 (in) 
              9 RETURN_VALUE         
and the tuple/list cases are again as in the original comment.

I'm in the process of running the full test suite.
History
Date User Action Args
2010-01-12 19:57:22dmalcolmsetrecipients: + dmalcolm, rhettinger, pitrou, alex
2010-01-12 19:57:21dmalcolmsetmessageid: <1263326241.2.0.265928262441.issue6690@psf.upfronthosting.co.za>
2010-01-12 19:57:18dmalcolmlinkissue6690 messages
2010-01-12 19:57:18dmalcolmcreate