Message97574
A few things about the patch:
1) the MarshallError class has a 'message' attribute that results in a warning on some Python versions, it should be renamed in something different (like 'msg');
2) I'm not sure why the <marshallerror></marshallerror> in the exception message is necessary, but I didn't look at the code in xmlrpclib.py so it might be ok;
3) the first 'pos' is not used in the for loop where it is created but only some lines later inside the except, this is not immediately clear, so a short comment should be added;
4) the str(e) is redundant -- there's already %s;
5) the "except Exception, e:" look suspicious, a more specific exception(s) should probably be specified;
6) 'as' should be used instead of the comma in the 'except' statements. |
|
Date |
User |
Action |
Args |
2010-01-11 05:15:27 | ezio.melotti | set | recipients:
+ ezio.melotti, loewis, blunck2, kristjan.jonsson, brian.curtin |
2010-01-11 05:15:27 | ezio.melotti | set | messageid: <1263186927.14.0.638374963893.issue2449@psf.upfronthosting.co.za> |
2010-01-11 05:15:25 | ezio.melotti | link | issue2449 messages |
2010-01-11 05:15:24 | ezio.melotti | create | |
|