Author pitrou lucifer, nirai, pitrou 2010-01-05.10:58:26 4.92124e-05 No <1262689108.14.0.740823736638.issue7610@psf.upfronthosting.co.za>
Content
> Since the peek is called with a value of 2, the newline sequence \r\n
> should be retrieved as is.

No, it doesn't follow. The \r can still appear at the end of a readahead, in which case your algorithm will not eliminate the following \n.

That is, if the sequence of readaheads is ['a\r', '\nb\n'], readlines() will return ['a\n', '\n', 'b\n'] while it should return ['a\n', 'b\n'].

It should be possible to construct a statistically valid test case for this, for example by creating an archived file containing 'a\r\n'*10000 and reading back from it.
History
Date User Action Args
2010-01-05 10:58:28pitrousetrecipients: + pitrou, nirai, lucifer
2010-01-05 10:58:28pitrousetmessageid: <1262689108.14.0.740823736638.issue7610@psf.upfronthosting.co.za>