Author pitrou
Recipients flox, pitrou
Date 2009-12-21.13:06:21
SpamBayes Score 2.74708e-10
Marked as misclassified No
Message-id <1261400826.3333.17.camel@localhost>
In-reply-to <1261400507.15.0.376089102862.issue7462@psf.upfronthosting.co.za>
Content
> Actually I see different macros which do the same thing: I will consider
> reusing STRINGLIB_CMP to re-define PyUNICODE_MATCH and PySTRING_MATCH
> (or create aliases if they have the same signature).

STRINGLIB_CMP, as the name implies, should only be used by stringlib.
(anything which doesn't start with Py* shouldn't be exported in the
official include files)

> But don't you think we should do this incrementally, i.e. commit the
> current patch before refactoring more code?

Well, if STRINGLIB_CMP isn't used anymore, removing it should be part of
the current issue. There's no reason to leave dead code in the source
tree. I agree that further cleanups can be part of another issue.
History
Date User Action Args
2009-12-21 13:06:23pitrousetrecipients: + pitrou, flox
2009-12-21 13:06:22pitroulinkissue7462 messages
2009-12-21 13:06:22pitroucreate