This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients barry, benjamin.peterson, janssen, kevinwatters, ncoghlan, r.david.murray, rhettinger, rmore, rtucker, scott.dial
Date 2009-12-07.14:48:10
SpamBayes Score 4.275278e-10
Marked as misclassified No
Message-id <1260197292.71.0.316804870227.issue5949@psf.upfronthosting.co.za>
In-reply-to
Content
IMO the context manager approach is much better than what I had.  I'm
still not used to using those :)

One request: I imported test_support as support because that's what it
is named in py3k, and doing it that way will make porting the patch to
py3k simpler.  It would also be nice to pep8ify the spacing by putting
two blank lines between classes (yeah, I know, a lot of the test source
is not PEP 8 compliant...but we try to keep any new code compliant, and
fix old code as we touch it).

Oh, and the reason I moved SocketServer below the import_module for
threading is that SocketServer will die on import if threading is not
available, so it seemed better to me to make the explicit check for
threading first.  Probably instead that import_module should be moved to
the top of the import list, since if it fails the module is skipped.
History
Date User Action Args
2009-12-07 14:48:12r.david.murraysetrecipients: + r.david.murray, barry, rhettinger, ncoghlan, janssen, scott.dial, kevinwatters, benjamin.peterson, rmore, rtucker
2009-12-07 14:48:12r.david.murraysetmessageid: <1260197292.71.0.316804870227.issue5949@psf.upfronthosting.co.za>
2009-12-07 14:48:11r.david.murraylinkissue5949 messages
2009-12-07 14:48:10r.david.murraycreate