This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author loewis
Recipients barry, chuck, exarkun, georg.brandl, gregory.p.smith, ivank, loewis, pitrou
Date 2009-11-23.08:37:05
SpamBayes Score 5.9327094e-06
Marked as misclassified No
Message-id <1258965429.09.0.933792121241.issue6071@psf.upfronthosting.co.za>
In-reply-to
Content
I think the error is really in _hashlib, not in the array object. It
should not require 3.x style buffers, but continue to support 2.x
readbuffers. Attached is a patch that takes this route to fixing the bug.

As for the checks for bf_releasebuffer: I still think they are
necessary. If an object implements bf_releasebuffer, that means that the
object may change the buffer underneath, unless proper locking and
unlocking takes place. Indeed, the array's getreadbuf operation is not
thread-safe. It might be possible to remove them if it is clarified that
anybody calling getreadbuffer must not release the GIL while they hold
on to the buffer.
History
Date User Action Args
2009-11-23 08:37:09loewissetrecipients: + loewis, barry, georg.brandl, gregory.p.smith, exarkun, pitrou, ivank, chuck
2009-11-23 08:37:09loewissetmessageid: <1258965429.09.0.933792121241.issue6071@psf.upfronthosting.co.za>
2009-11-23 08:37:07loewislinkissue6071 messages
2009-11-23 08:37:06loewiscreate