Message95615
I think the error is really in _hashlib, not in the array object. It
should not require 3.x style buffers, but continue to support 2.x
readbuffers. Attached is a patch that takes this route to fixing the bug.
As for the checks for bf_releasebuffer: I still think they are
necessary. If an object implements bf_releasebuffer, that means that the
object may change the buffer underneath, unless proper locking and
unlocking takes place. Indeed, the array's getreadbuf operation is not
thread-safe. It might be possible to remove them if it is clarified that
anybody calling getreadbuffer must not release the GIL while they hold
on to the buffer. |
|
Date |
User |
Action |
Args |
2009-11-23 08:37:09 | loewis | set | recipients:
+ loewis, barry, georg.brandl, gregory.p.smith, exarkun, pitrou, ivank, chuck |
2009-11-23 08:37:09 | loewis | set | messageid: <1258965429.09.0.933792121241.issue6071@psf.upfronthosting.co.za> |
2009-11-23 08:37:07 | loewis | link | issue6071 messages |
2009-11-23 08:37:06 | loewis | create | |
|