Author pitrou
Recipients giampaolo.rodola, gregory.p.smith, iElectric, janssen, jeffo, lgedgar, lszyba1, pitrou, qwavel, roberte, twhitema
Date 2009-10-15.17:56:35
SpamBayes Score 0.000293588
Marked as misclassified No
Message-id <1255629397.86.0.604915699447.issue2054@psf.upfronthosting.co.za>
In-reply-to
Content
Well, first some tests should be added.
As for reviewing, it needs to be done by someone competent with FTP and
SSL/TLS. If no such person is available and you are confident that the
patch is ok (and ready to do necessary maintenance), then perhaps you
can commit it. But please add tests first. It is really too easy to
accidentally break a functionality which is not exercised by the test suite.

Oh, and you need to update the documentation too :)
History
Date User Action Args
2009-10-15 17:56:37pitrousetrecipients: + pitrou, gregory.p.smith, janssen, giampaolo.rodola, roberte, iElectric, lszyba1, twhitema, jeffo, qwavel, lgedgar
2009-10-15 17:56:37pitrousetmessageid: <1255629397.86.0.604915699447.issue2054@psf.upfronthosting.co.za>
2009-10-15 17:56:36pitroulinkissue2054 messages
2009-10-15 17:56:36pitroucreate