Message93841
As far as I can tell, the patch looks mostly good.
I just wonder, in Util_HandleBZStreamEnd(), why you don't set self->mode
to MODE_CLOSED if BZ2_bzReadOpen() fails.
As a sidenote, the bz2 module implementation seems to have changed quite
a bit between trunk and py3k, so if you want it to be backported to
trunk (2.7), you'll have to provide a separate patch. |
|
Date |
User |
Action |
Args |
2009-10-10 20:11:35 | pitrou | set | recipients:
+ pitrou, akuchling, niemeyer, therve, thomaslee, r.david.murray, dbonner |
2009-10-10 20:11:35 | pitrou | set | messageid: <1255205495.53.0.134284426461.issue1625@psf.upfronthosting.co.za> |
2009-10-10 20:11:34 | pitrou | link | issue1625 messages |
2009-10-10 20:11:33 | pitrou | create | |
|