This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Andrei Korostelev
Recipients Andrei Korostelev
Date 2009-09-28.16:40:28
SpamBayes Score 5.5287863e-05
Marked as misclassified No
Message-id <1254156031.22.0.214966362027.issue7013@psf.upfronthosting.co.za>
In-reply-to
Content
HTTPResponse._read_chunked cannot handle "slightly" ill-formed HTTP
response not ended with 0 chunk-size. I did not make an analysis what
type of webservers generate such responses, but one of them is bing.com
(former msn.com).

Example correct chunked http response:

HTTP/1.1 200 OK
Content-Type: text/plain
Transfer-Encoding: chunked

B
first chunk

A
last chunk

0

Example chunked http rsponse not ended with zero length:

HTTP/1.1 200 OK
Content-Type: text/plain
Transfer-Encoding: chunked

B
first chunk

A
last chunk


Suggested solution: when an empty line is met where a hexadecimal
chunk-size is expected, treat it as the end of HTTP response. 

--- C:\Python25\Lib\httplib.py.orig	2008-02-12 20:48:24.000000000 +-0200
+++ C:\Python25\Lib\httplib.py.patched	2009-09-28 18:30:33.000000000 +-0200
@@ -542,12 +542,16 @@
         while True:
             if chunk_left is None:
                 line = self.fp.readline()
                 i = line.find(';')
                 if i >= 0:
                     line = line[:i] # strip chunk-extensions
+                # handle ill-formed response not ended with 0 chunk-size
+                line = line.strip()
+                if not line:
+                    break
                 chunk_left = int(line, 16)
                 if chunk_left == 0:
                     break
             if amt is None:
                 value += self._safe_read(chunk_left)
             elif amt < chunk_left:

Attached patches for Python-2.5, Python-2.6 and Python-3.1.
History
Date User Action Args
2009-09-28 16:40:31Andrei Korostelevsetrecipients: + Andrei Korostelev
2009-09-28 16:40:31Andrei Korostelevsetmessageid: <1254156031.22.0.214966362027.issue7013@psf.upfronthosting.co.za>
2009-09-28 16:40:29Andrei Korostelevlinkissue7013 messages
2009-09-28 16:40:28Andrei Korostelevcreate