Author mark.dickinson
Recipients mark.dickinson, nirinA, rhettinger, stutzbach, terry.reedy
Date 2009-09-21.14:30:53
SpamBayes Score 1.26576e-06
Marked as misclassified No
Message-id <1253543455.51.0.608919215107.issue3366@psf.upfronthosting.co.za>
In-reply-to
Content
Many thanks, Daniel.

> The patch against the trunk failed for PC/VC6/pythoncore.dsp.  I don't
> need that to build, though.

I've no idea why that would happen.  A line-ending issue, perhaps?  If 
it doesn't stop me committing the change, then perhaps it's not a 
problem.

> Your patch built fine, with one warning about a loss of precision on
> the following line in sinpi():
>
>    n = round(2.0*y);
>
>I recommend explicitly casting the result of round() to int, to get
>rid of the warning and because explicit is better than implicit. :)

Done.  Thanks!
History
Date User Action Args
2009-09-21 14:30:55mark.dickinsonsetrecipients: + mark.dickinson, rhettinger, terry.reedy, stutzbach, nirinA
2009-09-21 14:30:55mark.dickinsonsetmessageid: <1253543455.51.0.608919215107.issue3366@psf.upfronthosting.co.za>
2009-09-21 14:30:54mark.dickinsonlinkissue3366 messages
2009-09-21 14:30:54mark.dickinsoncreate