Author loewis
Recipients amaury.forgeotdarc, dmalcolm, gregory.p.smith, loewis, solinym
Date 2009-09-17.08:17:52
SpamBayes Score 5.17485e-06
Marked as misclassified No
Message-id <1253175473.93.0.186193753898.issue6508@psf.upfronthosting.co.za>
In-reply-to
Content
Your patch looks right, although I have a few style issues:
- the if chaining looks complicated: we don't usually have an else when 
the if returns
- make sure you use tabs consistently with the rest of the file
- it may be better to use uid_t where appropriate, see issue6873
History
Date User Action Args
2009-09-17 08:17:54loewissetrecipients: + loewis, gregory.p.smith, amaury.forgeotdarc, solinym, dmalcolm
2009-09-17 08:17:53loewissetmessageid: <1253175473.93.0.186193753898.issue6508@psf.upfronthosting.co.za>
2009-09-17 08:17:52loewislinkissue6508 messages
2009-09-17 08:17:52loewiscreate