Author ryles
Recipients agillesp, ryles
Date 2009-08-26.04:44:39
SpamBayes Score 1.20043e-12
Marked as misclassified No
Message-id <1251261886.79.0.822743960093.issue6759@psf.upfronthosting.co.za>
In-reply-to
Content
Hi Art,

Thanks for working on this. I've taken a look at the patch.

The fix to read_test looks correct. Of course, I would consider a more
descriptive variable name than 'b'.

The changes to read() are an improvement, but I think we need to be
careful when we replace "\r\n" with "\n". Basically, we've turned two
characters into one and are now potentially one character short of
'size' bytes. This doesn't match the behavior of file.read().

Another thing to work out is the lack of the 'newlines' attribute,
discussed in PEP 278.

I've noted that bz2 seems to do a pretty good job with universal newline
handling: python/trunk/Modules/bz2module.c.

It's in C, however, and I don't think there's actually anything in the
library doing UL in pure Python.
History
Date User Action Args
2009-08-26 04:44:47rylessetrecipients: + ryles, agillesp
2009-08-26 04:44:46rylessetmessageid: <1251261886.79.0.822743960093.issue6759@psf.upfronthosting.co.za>
2009-08-26 04:44:43ryleslinkissue6759 messages
2009-08-26 04:44:41rylescreate