This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, ezio.melotti, solinym, travis
Date 2009-08-20.00:09:16
SpamBayes Score 5.4527205e-05
Marked as misclassified No
Message-id <1250726959.32.0.843030729655.issue5210@psf.upfronthosting.co.za>
In-reply-to
Content
Some comments about the patch:
- In zlibmodule.c, the is_finished member should be an int, and converted 
to a PyObject only when requested.
- The test should check that is_finished is False one byte before the 
compressed part, and becomes True when the decompressor reads the last 
compressed byte.  I don't think that dco.flush() is necessary for the 
test.
- Also, the last check could be more precise: assertEquals(y1 + y2, 
HAMLET_SCENE) and assertEquals(dco.unused_data, HAMLET_SCENE)
History
Date User Action Args
2009-08-20 00:09:21amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, ezio.melotti, travis, solinym
2009-08-20 00:09:19amaury.forgeotdarcsetmessageid: <1250726959.32.0.843030729655.issue5210@psf.upfronthosting.co.za>
2009-08-20 00:09:17amaury.forgeotdarclinkissue5210 messages
2009-08-20 00:09:16amaury.forgeotdarccreate