Message91757
Some comments about the patch:
- In zlibmodule.c, the is_finished member should be an int, and converted
to a PyObject only when requested.
- The test should check that is_finished is False one byte before the
compressed part, and becomes True when the decompressor reads the last
compressed byte. I don't think that dco.flush() is necessary for the
test.
- Also, the last check could be more precise: assertEquals(y1 + y2,
HAMLET_SCENE) and assertEquals(dco.unused_data, HAMLET_SCENE) |
|
Date |
User |
Action |
Args |
2009-08-20 00:09:21 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, ezio.melotti, travis, solinym |
2009-08-20 00:09:19 | amaury.forgeotdarc | set | messageid: <1250726959.32.0.843030729655.issue5210@psf.upfronthosting.co.za> |
2009-08-20 00:09:17 | amaury.forgeotdarc | link | issue5210 messages |
2009-08-20 00:09:16 | amaury.forgeotdarc | create | |
|