Author pitrou
Recipients alexandre.vassalotti, bob.ippolito, ede, josiahcarlson, loewis, mark.dickinson, mwh, pitrou, rhettinger, tim.peters
Date 2009-08-15.11:49:13
SpamBayes Score 0.00898568
Marked as misclassified No
Message-id <1250336956.2.0.619678755033.issue1023290@psf.upfronthosting.co.za>
In-reply-to
Content
I agree with the comments which were made on the following points:
- please use consistent naming (`as_bytes` / `from_bytes`, or `asbytes`
/ `frombytes`; my preference goes to the former, especially now that we
have `bit_length`)
- default byteorder should be native, certainly not big endian which is
a small minority amongst today's computers
- you should synchronize with the python-ideas discussion, so that the
final API gets validated more publicly; it would not be very pleasant
for a patch to be committed if discussion were still in flux, and
perhaps with different conclusions as to the API which should be adopted

Besides, your patch has indentation problems (mixed spaces and tabs).
History
Date User Action Args
2009-08-15 11:49:16pitrousetrecipients: + pitrou, mwh, tim.peters, loewis, rhettinger, josiahcarlson, bob.ippolito, mark.dickinson, alexandre.vassalotti, ede
2009-08-15 11:49:16pitrousetmessageid: <1250336956.2.0.619678755033.issue1023290@psf.upfronthosting.co.za>
2009-08-15 11:49:13pitroulinkissue1023290 messages
2009-08-15 11:49:13pitroucreate