This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author casevh
Recipients casevh, jyasskin, mark.dickinson
Date 2009-07-16.22:55:25
SpamBayes Score 1.7938767e-09
Marked as misclassified No
Message-id <99e0b9530907161555qb03ac6al142d9327f96dc714@mail.gmail.com>
In-reply-to <1247769273.72.0.0927937922347.issue6431@psf.upfronthosting.co.za>
Content
On Thu, Jul 16, 2009 at 11:34 AM, Mark Dickinson<report@bugs.python.org> wrote:
>
> Mark Dickinson <dickinsm@gmail.com> added the comment:
>
> Thanks again, casevh!  The patch looks good.  I've added to it a bit,
> though---see issue6431.patch.  In detail:
>
> - don't use subtraction with unknown types for <, <=, >, >=;  this is
>  dangerous, since the unknown type may well do a lossy conversion, and
>  comparisons should really be exact where possible;  as with __eq__,
>  it seems better to return NotImplemented and give the other type a
>  chance.
>
> - handle infs and nans correctly in comparisons with floats
>
> - a few more tests.
>
> casevh, please could you have a look at the attached patch and let me
> know whether it still works with your gmpy port?

I've tested gmpy with attached patch and all tests pass successfully.
Thanks!

>
> Jeffrey, any comments on these changes?
>
> ----------
> stage: test needed -> patch review
> Added file: http://bugs.python.org/file14508/issue6431.patch
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue6431>
> _______________________________________
>
History
Date User Action Args
2009-07-16 22:55:27casevhsetrecipients: + casevh, mark.dickinson, jyasskin
2009-07-16 22:55:26casevhlinkissue6431 messages
2009-07-16 22:55:25casevhcreate