Message89338
The try statement at the end of hashlib.py is some of the worst python
code I've had the mispleasure of reading for a long time.
Secondly, it seems flawed in function as well as form.
__get_builtin_constructor can throw an ImportError, which seems
erroneously caught in the except (why on earth does the except span more
than the "import _hashlib"? That's bad style for precisely this reason.)
This will cause an error in the import of hashlib when there are
possibly many working hash functions already imported. Changing the:
try:
exec funcName + ' = __get_builtin_constructor(funcName)'
except ValueError:
pass
to catch ImportError as well solves the problem for me. |
|
Date |
User |
Action |
Args |
2009-06-13 22:45:31 | Eloff | set | recipients:
+ Eloff |
2009-06-13 22:45:31 | Eloff | set | messageid: <1244933131.5.0.604284990762.issue6281@psf.upfronthosting.co.za> |
2009-06-13 22:45:29 | Eloff | link | issue6281 messages |
2009-06-13 22:45:28 | Eloff | create | |
|