Message89152
When an error occurs in a StreamRequestHandler, its wfile and rfile
members are not closed. This causes the underlaying socket to stay
alive and and it is therefore not closed, even when the SocketServer
closes it in server.close_request(). This means that a client will not
know that there is no one listening on the other end.
This is due to incorrect error handling semantics in BaseRequestHandler.
This patch fixes the error handling in BaseRequestHandler, ensuring that
request.finish() is called when request.setup() has completed.
I also add an explicit socket.shutdown() in TCPServer.close_request() to
make sure that at least a half-close occurs even in the face of socket
reference leaks. |
|
Date |
User |
Action |
Args |
2009-06-09 16:55:38 | kristjan.jonsson | set | recipients:
+ kristjan.jonsson |
2009-06-09 16:55:38 | kristjan.jonsson | set | messageid: <1244566538.72.0.477638958657.issue6248@psf.upfronthosting.co.za> |
2009-06-09 16:55:37 | kristjan.jonsson | link | issue6248 messages |
2009-06-09 16:55:36 | kristjan.jonsson | create | |
|