This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author kristjan.jonsson
Recipients kristjan.jonsson
Date 2009-06-09.16:55:36
SpamBayes Score 4.8193748e-08
Marked as misclassified No
Message-id <1244566538.72.0.477638958657.issue6248@psf.upfronthosting.co.za>
In-reply-to
Content
When an error occurs in a StreamRequestHandler, its wfile and rfile 
members are not closed.  This causes the underlaying socket to stay 
alive and and it is therefore not closed, even when the SocketServer 
closes it in server.close_request().  This means that a client will not 
know that there is no one listening on the other end.

This is due to incorrect error handling semantics in BaseRequestHandler.

This patch fixes the error handling in BaseRequestHandler, ensuring that 
request.finish() is called when request.setup() has completed.

I also add an explicit socket.shutdown() in TCPServer.close_request() to 
make sure that at least a half-close occurs even in the face of socket 
reference leaks.
History
Date User Action Args
2009-06-09 16:55:38kristjan.jonssonsetrecipients: + kristjan.jonsson
2009-06-09 16:55:38kristjan.jonssonsetmessageid: <1244566538.72.0.477638958657.issue6248@psf.upfronthosting.co.za>
2009-06-09 16:55:37kristjan.jonssonlinkissue6248 messages
2009-06-09 16:55:36kristjan.jonssoncreate