Author alexandre.vassalotti
Recipients alexandre.vassalotti, mkiever, pitrou
Date 2009-06-04.01:18:45
SpamBayes Score 1.36907e-12
Marked as misclassified No
Message-id <1244078338.83.0.368374964017.issue6137@psf.upfronthosting.co.za>
In-reply-to
Content
Here is an updated patch based on Antoine's latest patch.

Summary of changes:
 * Updated docstrings of Pickler and Unpickler in the pickle module.
 * Fixed pickle._Pickler to consider fix_imports only for protocol < 3
 * Made module name remapping in _pickle more robust:
    - added PyUnicode_Check on global_name and module_name;
    - used PyDict_GetItemWithError instead of PyDict_GetItem
 * Changed Py_BuildValue("(OO)", ...) to its faster equivalent
   PyTuple_Pack(2, ...).

I don't really the idea of remapping names generated by Pickler, since
it breaks the identity guarantee in save_global(). However, I agree this
is an example where practicality beats purity. So, I do not oppose to
the change.
History
Date User Action Args
2009-06-04 01:18:59alexandre.vassalottisetrecipients: + alexandre.vassalotti, pitrou, mkiever
2009-06-04 01:18:58alexandre.vassalottisetmessageid: <1244078338.83.0.368374964017.issue6137@psf.upfronthosting.co.za>
2009-06-04 01:18:57alexandre.vassalottilinkissue6137 messages
2009-06-04 01:18:56alexandre.vassalotticreate