Message88684
Some comments on the patch:
- I don't understand why you create a static "twotuple" object rather
than simply using Py_BuildValue("(OO)", ...). Mutating tuples is bad.
- I don't think you need to call PyDict_Contains() before
PyDict_GetItem(). The latter will simply return NULL if the key isn't found.
- You should check whether the item fetched from the dictionary has the
right datatype (tuple for name_mapping, str for import_mapping). Anyone
can change (monkeypatch) _pickle_compat and make the interpreter crash. |
|
Date |
User |
Action |
Args |
2009-06-01 23:11:53 | pitrou | set | recipients:
+ pitrou, mkiever, alexandre.vassalotti |
2009-06-01 23:11:53 | pitrou | set | messageid: <1243897913.45.0.481341027976.issue6137@psf.upfronthosting.co.za> |
2009-06-01 23:11:52 | pitrou | link | issue6137 messages |
2009-06-01 23:11:51 | pitrou | create | |
|