Author pitrou
Recipients alexandre.vassalotti, mkiever, pitrou
Date 2009-06-01.23:11:51
SpamBayes Score 1.45606e-13
Marked as misclassified No
Message-id <1243897913.45.0.481341027976.issue6137@psf.upfronthosting.co.za>
In-reply-to
Content
Some comments on the patch:
- I don't understand why you create a static "twotuple" object rather
than simply using Py_BuildValue("(OO)", ...). Mutating tuples is bad.
- I don't think you need to call PyDict_Contains() before
PyDict_GetItem(). The latter will simply return NULL if the key isn't found.
- You should check whether the item fetched from the dictionary has the
right datatype (tuple for name_mapping, str for import_mapping). Anyone
can change (monkeypatch) _pickle_compat and make the interpreter crash.
History
Date User Action Args
2009-06-01 23:11:53pitrousetrecipients: + pitrou, mkiever, alexandre.vassalotti
2009-06-01 23:11:53pitrousetmessageid: <1243897913.45.0.481341027976.issue6137@psf.upfronthosting.co.za>
2009-06-01 23:11:52pitroulinkissue6137 messages
2009-06-01 23:11:51pitroucreate