This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author collinwinter
Recipients alexandre.vassalotti, amaury.forgeotdarc, collinwinter, feisan, pitrou
Date 2009-05-25.05:44:06
SpamBayes Score 2.3044444e-10
Marked as misclassified No
Message-id <1243230249.72.0.733921424496.issue5670@psf.upfronthosting.co.za>
In-reply-to
Content
Fixed the len(d) == 1 size regression. Final performance of the patch
relative to trunk:

Using Unladen Swallow's perf.py -b pickle,pickle_dict on trunk:
pickle:
Min: 2.238 -> 1.895: 18.08% faster
Avg: 2.241 -> 1.898: 18.04% faster
Significant (t=282.066701, a=0.95)

pickle_dict:
Min: 2.163 -> 1.375: 57.36% faster
Avg: 2.168 -> 1.376: 57.50% faster
Significant (t=527.668441, a=0.95)


Performance for py3k:
pickle:
Min: 2.849 -> 2.790: 2.10% faster
Avg: 2.854 -> 2.796: 2.09% faster
Significant (t=27.624303, a=0.95)

pickle_dict:
Min: 2.121 -> 1.512: 40.27% faster
Avg: 2.128 -> 1.519: 40.13% faster
Significant (t=283.406572, a=0.95)


regrtest.py -uall test_xpickle passes all backwards-compatibility tests
for trunk, and all other tests run by regrtest.py on Linux pass.

Committed as r72909 (trunk), r72910 (py3k).
History
Date User Action Args
2009-05-25 05:44:10collinwintersetrecipients: + collinwinter, amaury.forgeotdarc, pitrou, alexandre.vassalotti, feisan
2009-05-25 05:44:09collinwintersetmessageid: <1243230249.72.0.733921424496.issue5670@psf.upfronthosting.co.za>
2009-05-25 05:44:08collinwinterlinkissue5670 messages
2009-05-25 05:44:07collinwintercreate