Author jaraco
Recipients giampaolo.rodola, jafo, jaraco, lemburg, loewis, nnorwitz, swarren
Date 2009-05-24.16:06:41
SpamBayes Score 1.01394e-09
Marked as misclassified No
Message-id <8B473FAE8A08C34C9F5666FD4B0A87B67502A1A9C7@hornigold.jaraco.com>
In-reply-to <4A1703CE.7010206@v.loewis.de>
Content
Thanks again Martin for the guidance.  It proved quite helpful in completing 
this patch.

This latest version (3) compiles and has been tested under Windows Vista and 
Windows XP and behaves as expected (with a NotImplemented error under XP).

I did find that I had to tweak the behavior of stat.S_ISLNK because my 
implementation of the st_mode bits for a symlink has different values than 
that of a posix call.  I don't fully understand the implications of my 
implementation.

An alternate implementation would be to have set_symlink_stat[AW] reset all of 
the st_mode flags except for 0o120000, to be consistent with what is returned 
by a posix stat call.  This approach doesn't seem quite right either.  I would 
appreciate a comment on this by someone more familiar with this type of 
problem.

Other than that issue, what else needs to be addressed to get this patch 
integrated into the 3.1 or 3.1.1 release?
Files
File name Uploaded
smime.p7s jaraco, 2009-05-24.16:06:41
windows symlink draft 3.patch jaraco, 2009-05-24.16:06:38
History
Date User Action Args
2009-05-24 16:06:44jaracosetrecipients: + jaraco, lemburg, loewis, nnorwitz, jafo, giampaolo.rodola, swarren
2009-05-24 16:06:42jaracolinkissue1578269 messages
2009-05-24 16:06:41jaracocreate