Message87458
With Giampaolo's suggested change, all tests pass. My understanding of
what asyncore/asynchat is intended to do and how it might be used in
practice is weak, so I don't feel qualified to comment on the
correctness of the change.
> One of the issues with using the method that Giampaolo describes,
which
> I explained to him, is that generally if someone sends you data, you
> want to receive it. You can get both data and the signal that someone
> disconnected, in particular, with asynchat's .close_when_done()
method.
Is it possible to add a test for this sort of situation, to make sure
that future changes take it into account? |
|
Date |
User |
Action |
Args |
2009-05-08 18:53:37 | mark.dickinson | set | recipients:
+ mark.dickinson, facundobatista, josiahcarlson, alanmcintyre, giampaolo.rodola, donmez, MrJean1, r.david.murray |
2009-05-08 18:53:37 | mark.dickinson | set | messageid: <1241808817.71.0.634048945939.issue5798@psf.upfronthosting.co.za> |
2009-05-08 18:53:36 | mark.dickinson | link | issue5798 messages |
2009-05-08 18:53:36 | mark.dickinson | create | |
|