Message86025
I think that in r69448, the test does not match the code:
codecs.getwriter('cp1251') has no attribute 'encoding', and no function
in test_logging ever pass a stream with an explicit encoding.
Also, the test in emit() should be reversed, otherwise msg.encode() is
called only when msg is a 8bit string. And in this case, a unicode
string should be passed to the stream.
See attached patch.
The codecs.getwriter should probably grow an 'encoding' attribute
automatically, but this is another issue. |
|
Date |
User |
Action |
Args |
2009-04-16 12:32:00 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, vinay.sajip, methane |
2009-04-16 12:32:00 | amaury.forgeotdarc | set | messageid: <1239885120.67.0.462939651133.issue5768@psf.upfronthosting.co.za> |
2009-04-16 12:31:59 | amaury.forgeotdarc | link | issue5768 messages |
2009-04-16 12:31:59 | amaury.forgeotdarc | create | |
|