This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, methane, vinay.sajip
Date 2009-04-16.12:31:59
SpamBayes Score 4.158746e-08
Marked as misclassified No
Message-id <>
I think that in r69448, the test does not match the code:
codecs.getwriter('cp1251') has no attribute 'encoding', and no function
in test_logging ever pass a stream with an explicit encoding.

Also, the test in emit() should be reversed, otherwise msg.encode() is
called only when msg is a 8bit string. And in this case, a unicode
string should be passed to the stream.

See attached patch.
The codecs.getwriter should probably grow an 'encoding' attribute
automatically, but this is another issue.
Date User Action Args
2009-04-16 12:32:00amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, vinay.sajip, methane
2009-04-16 12:32:00amaury.forgeotdarcsetmessageid: <>
2009-04-16 12:31:59amaury.forgeotdarclinkissue5768 messages
2009-04-16 12:31:59amaury.forgeotdarccreate