Message84258
Thanks for the patch. A couple of questions and comments:
(1) at line 300-ish of test_struct, should (struct.error, TypeError) be
(struct.error, OverflowError)? I don't think out-of-range values should
be raising TypeError. If they are, perhaps we should change that.
(2) It looks like the deprecated_err function isn't needed any more
(yay!); let's remove it.
(3) I'd prefer to keep the test_1229380 bit, but just replace the
deprecated_err with an assertRaises, just like you already did further
up. As far as I can see those tests aren't entirely duplicated by
others, and one can never have too many tests... |
|
Date |
User |
Action |
Args |
2009-03-27 13:47:39 | mark.dickinson | set | recipients:
+ mark.dickinson, andreas.schawo |
2009-03-27 13:47:38 | mark.dickinson | set | messageid: <1238161658.9.0.621534209637.issue5463@psf.upfronthosting.co.za> |
2009-03-27 13:47:37 | mark.dickinson | link | issue5463 messages |
2009-03-27 13:47:36 | mark.dickinson | create | |
|