Author pitrou
Recipients pitrou, vstinner
Date 2009-03-26.17:41:33
SpamBayes Score 3.06213e-09
Marked as misclassified No
Message-id <1238089369.8107.16.camel@fsol>
In-reply-to <200903261826.18853.victor.stinner@haypocalc.com>
Content
Le jeudi 26 mars 2009 à 17:26 +0000, STINNER Victor a écrit :
> STINNER Victor <victor.stinner@haypocalc.com> added the comment:
> 
> > - I'm not sure why you make self->ok handling more complicated than it was
> 
> tell() requires self->ok=1. I choosed to reset self->ok to zero on error, but 
> it's maybe useless.

You are calling tell() on the underlying binary buffer, not on the
TextIOWrapper object. So self->ok should have no impact. Am I missing
something?

> self>encodefunc value have to be changed because <encoder>.setstate() changes 
> the encoding function: UTF-16 => UTF-16-LE or UTF-16-BE.

I know, but then the logic should probably be changed and use an
additional struct member to signal that the start of file has been
skipped.
History
Date User Action Args
2009-03-26 17:41:35pitrousetrecipients: + pitrou, vstinner
2009-03-26 17:41:34pitroulinkissue5006 messages
2009-03-26 17:41:33pitroucreate