Message83967
A few comments:
I think PyLong_SIGN and PyLong_EQUALS_ZERO should go in
Include/longobject.h, not Include/longintrepr.h: these 2 macros have an
unambiguous meaning for *any* representation of integers. And
longintrepr.h is really supposed to be private, for the use of
longobject.c only. PyLong_NDIGITS should stay in longintrepr.h, though,
since it's dependent on the representation.
Perhaps rename PyLong_EQUALS_ZERO to PyLong_IS_ZERO?
Almost all your uses of PyLong_SIGN take the form PyLong_SIGN(X) < 0.
Maybe it would be better to have a PyLong_IS_NEGATIVE macro instead? |
|
Date |
User |
Action |
Args |
2009-03-22 10:42:04 | mark.dickinson | set | recipients:
+ mark.dickinson, gregory.p.smith, pernici, vstinner, christian.heimes |
2009-03-22 10:42:03 | mark.dickinson | set | messageid: <1237718523.83.0.230820220427.issue4294@psf.upfronthosting.co.za> |
2009-03-22 10:42:02 | mark.dickinson | link | issue4294 messages |
2009-03-22 10:42:01 | mark.dickinson | create | |
|