Author loewis
Recipients akuchling, amaury.forgeotdarc, collinwinter, ezio.melotti, georg.brandl, jimjjewett, loewis, mark, moreati, mrabarnett, nneonneo, pitrou, rsc, timehorse
Date 2009-03-07.11:27:05
SpamBayes Score 2.88658e-15
Marked as misclassified No
Message-id <1236425229.32.0.883457945066.issue2636@psf.upfronthosting.co.za>
In-reply-to
Content
I don't think it will be possible to accept these patches in the current
form and way in which they are presented. I randomly picked
issue2636-features-2.diff, and see that it contains lots of style and
formatting changes, which is completely taboo for this kind of contribution.

I propose to split up the patches into separate tracker issues, one
issue per proposed new feature. No need to migrate all changes to new
issues - start with the one single change that you think is already
complete, and acceptance is likely without debate. Leave a note in this
issue what change has been moved to what issue.

For each such new issue, describe what precisely the patch is supposed
to do. Make sure it is complete with respect to this specific change,
and remove any code not contributing to the change.

Also procedurally, it is not quite clear to me who is contributing these
changes: Jeffrey C. Jacobs, or Matthew Barnett. We will need copyright
forms from the original contributor.
History
Date User Action Args
2009-03-07 11:27:09loewissetrecipients: + loewis, akuchling, georg.brandl, collinwinter, jimjjewett, amaury.forgeotdarc, pitrou, nneonneo, rsc, timehorse, mark, ezio.melotti, mrabarnett, moreati
2009-03-07 11:27:09loewissetmessageid: <1236425229.32.0.883457945066.issue2636@psf.upfronthosting.co.za>
2009-03-07 11:27:06loewislinkissue2636 messages
2009-03-07 11:27:05loewiscreate