Author vstinner
Recipients christian.heimes, collinwinter, gregory.p.smith, jyasskin, loewis, mark.dickinson, pernici, pitrou, schuppenies, tim.peters, vstinner
Date 2009-02-26.23:52:49
SpamBayes Score 5.55848e-10
Marked as misclassified No
Message-id <1235692371.94.0.3513809271.issue4258@psf.upfronthosting.co.za>
In-reply-to
Content
1 comment and 1 question about 30bit_longdigit20.patch:
 - I love fixed size type: you use them when PYLONG_BITS_IN_DIGIT == 
30 (eg. digit=PY_UINT32_T) but not when PYLONG_BITS_IN_DIGIT == 15 
(eg. digit=unsigned short). Even if short is always 16 bits, I would 
prefer fixed size types in any case.
 - In pyport.h, you redefine PYLONG_BITS_IN_DIGIT if it's not set. Is 
it for the Windows world (which doesn't use configure script)?

I prefer the patch version 20 because it's much simplier than the 
other with the algorithm optimisations. The patch is already huge, so 
it's better to split it into smaller parts ;-)
History
Date User Action Args
2009-02-26 23:52:52vstinnersetrecipients: + vstinner, tim.peters, loewis, collinwinter, gregory.p.smith, mark.dickinson, pitrou, pernici, christian.heimes, jyasskin, schuppenies
2009-02-26 23:52:51vstinnersetmessageid: <1235692371.94.0.3513809271.issue4258@psf.upfronthosting.co.za>
2009-02-26 23:52:50vstinnerlinkissue4258 messages
2009-02-26 23:52:49vstinnercreate