Author mark.dickinson
Recipients dalcinl, mark.dickinson, tim.peters
Date 2009-02-10.13:50:05
SpamBayes Score 4.73122e-13
Marked as misclassified No
Message-id <1234273811.17.0.461849233545.issue5175@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch!

I agree that the 'versionchanged' reference should be added in the docs.
 I also think that the test should be updated to check the exception type.

Here's a modified version of your patch that adds a test for
OverflowError to the capi tests, adds 'versionchanged', and rewords the
docs slightly.  I also took the liberty of rewording the docs for
PyLong_AsLongLong, to match.  I've tested this on a 64-bit linux
machine, and checked that the docs build properly.  I'll test on 32-bit
and 64-bit OS X later today.

Lisandro, does this updated patch work for you?
History
Date User Action Args
2009-02-10 13:50:11mark.dickinsonsetrecipients: + mark.dickinson, tim.peters, dalcinl
2009-02-10 13:50:11mark.dickinsonsetmessageid: <1234273811.17.0.461849233545.issue5175@psf.upfronthosting.co.za>
2009-02-10 13:50:09mark.dickinsonlinkissue5175 messages
2009-02-10 13:50:09mark.dickinsoncreate