Author mhammond
Recipients amaury.forgeotdarc, kristjan.jonsson, loewis, mhammond
Date 2009-01-31.23:39:10
SpamBayes Score 0.000205474
Marked as misclassified No
Message-id <1233445152.98.0.929881174119.issue4804@psf.upfronthosting.co.za>
In-reply-to
Content
I believe your new patch suffers the same problem.  Consider the blocks
like:

+	/* turn off crt asserts on windows since we have no control over fd */
+	Py_BEGIN_CRT_ERROR_HANDLING
 	Py_BEGIN_ALLOW_THREADS
 	size = write(fd, pbuf.buf, (size_t)pbuf.len);
 	Py_END_ALLOW_THREADS
+	Py_END_CRT_ERROR_HANDLING

And consider Martin's comments in msg80191: Here you have T1 setting a
global mode, then releasing the GIL.  Other threads are then free to run
and may do the same and depending on the order the threads do things,
the global setting may not end up where it started.
History
Date User Action Args
2009-01-31 23:39:13mhammondsetrecipients: + mhammond, loewis, amaury.forgeotdarc, kristjan.jonsson
2009-01-31 23:39:12mhammondsetmessageid: <1233445152.98.0.929881174119.issue4804@psf.upfronthosting.co.za>
2009-01-31 23:39:11mhammondlinkissue4804 messages
2009-01-31 23:39:10mhammondcreate