Message80791
> I don't like the change of API to PyTokenizer_FromString.
> I would prefer another function like
PyTokenizer_IgnoreCodingCookie()
Ok, I created a new function PyTokenizer_FromUnicode(). I
choosed "FromUnicode" because the string is encoded in unicode (as
UTF-8, even if it's not the wchar_t* type).
> The (char *) cast in PyTokenizer_FromString is unneeded.
The cast on the decode_str() result? It was already present in the
original code. I removed it in my new patch.
> You need to indent the "else" clause after you test for
ignore_cookie.
Ooops, I always have problems to generate a diff because my editor
removes trailing spaces and then I have to ignore space changes to
create the diff.
> I'd like to see a test that shows that byte strings still have their
cookies examined.
test_pep263 has already two tests using a "#coding:" header. |
|
Date |
User |
Action |
Args |
2009-01-29 23:13:38 | vstinner | set | recipients:
+ vstinner, brett.cannon, sjmachin, amaury.forgeotdarc, benjamin.peterson |
2009-01-29 23:13:38 | vstinner | set | messageid: <1233270818.59.0.883381370647.issue4626@psf.upfronthosting.co.za> |
2009-01-29 23:13:37 | vstinner | link | issue4626 messages |
2009-01-29 23:13:36 | vstinner | create | |
|