Author ncoghlan
Recipients brett.cannon, christian.heimes, exarkun, loewis, ncoghlan, rhettinger, ross.light
Date 2009-01-26.01:42:26
SpamBayes Score 4.75983e-08
Marked as misclassified No
Message-id <1232934147.44.0.908530354037.issue4285@psf.upfronthosting.co.za>
In-reply-to
Content
Rather than deleting the isinstance() check from the tests completely, I
suggest changing it to be:

self.assert_(isinstance(vi[:], tuple))

Also, comparing directly with a tuple is also a fairly common use of
version_info so it would be worth adding a test to explicitly guarantee
that comparison:

self.assert_(vi > (1,0,0))

Patch applied and built cleanly for me, but I haven't checked the doc
build yet.
History
Date User Action Args
2009-01-26 01:42:27ncoghlansetrecipients: + ncoghlan, loewis, brett.cannon, rhettinger, exarkun, christian.heimes, ross.light
2009-01-26 01:42:27ncoghlansetmessageid: <1232934147.44.0.908530354037.issue4285@psf.upfronthosting.co.za>
2009-01-26 01:42:26ncoghlanlinkissue4285 messages
2009-01-26 01:42:26ncoghlancreate