Message80557
Rather than deleting the isinstance() check from the tests completely, I
suggest changing it to be:
self.assert_(isinstance(vi[:], tuple))
Also, comparing directly with a tuple is also a fairly common use of
version_info so it would be worth adding a test to explicitly guarantee
that comparison:
self.assert_(vi > (1,0,0))
Patch applied and built cleanly for me, but I haven't checked the doc
build yet. |
|
Date |
User |
Action |
Args |
2009-01-26 01:42:27 | ncoghlan | set | recipients:
+ ncoghlan, loewis, brett.cannon, rhettinger, exarkun, christian.heimes, ross.light |
2009-01-26 01:42:27 | ncoghlan | set | messageid: <1232934147.44.0.908530354037.issue4285@psf.upfronthosting.co.za> |
2009-01-26 01:42:26 | ncoghlan | link | issue4285 messages |
2009-01-26 01:42:26 | ncoghlan | create | |
|