This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients amaury.forgeotdarc, benjamin.peterson, brett.cannon, christian.heimes, georg.brandl, lemburg, mark.dickinson, pitrou, rhettinger
Date 2009-01-25.12:14:22
SpamBayes Score 5.73919e-11
Marked as misclassified No
Message-id <>
I'm wondering how to move forward with this issue.  Might it make sense to 
break the current monster patch into a series of more-easily reviewed 
patches?  I was thinking of something like:

 - patch 1 (Python code): remove all uses of cmp from std. lib. and tests
 - patch 2 (C code): remove all uses of tp_compare from Modules and 
 - patch 3 : rename tp_compare to tp_reserved in all Modules and Objects 
(should be a very simple patch, but touches a lot of files)
 - patch 4 : fix docs, and look for any other loose ends that need
   cleaning up.

Here's patch 1: remove uses of cmp from library and tests (and also from 
Tools/unicode/  It involves essentially no user-
visible changes.  (At least, assuming that users aren't trying to access 
e.g., UserString.__cmp__ directly.)

The patch is against py3k.  All tests pass on my machine with this patch 

Anyone interested in reviewing this?
Date User Action Args
2009-01-25 12:14:37mark.dickinsonsetrecipients: + mark.dickinson, lemburg, brett.cannon, georg.brandl, rhettinger, amaury.forgeotdarc, pitrou, christian.heimes, benjamin.peterson
2009-01-25 12:14:36mark.dickinsonsetmessageid: <>
2009-01-25 12:14:35mark.dickinsonlinkissue1717 messages
2009-01-25 12:14:33mark.dickinsoncreate