Message80203
> What is the rationale for swallowing all socket exceptions except
> "Connection reset by peer" in __exit__?
I am catching just the error that raises if the connection is closed
when calling quit()
> In any case, it is better to use errno.ECONNRESET instead of literal 54.
Right
> Note that SMTP.quit() calls SMTP.close(), so in the normal termination
> case, close will be called twice. This is not a real problem since
> SMTP.close() is a noop on a closed SMTP object, but it does not look
> right.
Right i'll fix that
Thanks for teh feedback
The double call to close() also makes error path harder to analyze. It
appears that if a socket error is raised in the first call to close, it
gets caught only to be raised again in the second call (assuming a
persistent error). |
|
Date |
User |
Action |
Args |
2009-01-19 19:01:24 | tarek | set | recipients:
+ tarek, belopolsky |
2009-01-19 19:01:23 | tarek | set | messageid: <1232391683.93.0.000703948725121.issue4972@psf.upfronthosting.co.za> |
2009-01-19 19:01:23 | tarek | link | issue4972 messages |
2009-01-19 19:01:23 | tarek | create | |
|