This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients mark.dickinson, pitrou
Date 2009-01-13.21:55:36
SpamBayes Score 0.014699339
Marked as misclassified No
Message-id <1231883797.56.0.848554709303.issue4935@psf.upfronthosting.co.za>
In-reply-to
Content
What's the purpose of old_i?  It looks like it's never used for anything.

Other than than, the patch looks good to me.

I'd guess that the "if (i < 0)" was simply optimized away.  This isn't 
necessarily a compiler bug: if I understand correctly, a strict reading of 
the C standards says it's legitimate for a compiler to assume that code is 
written in such a way that signed-arithmetic overflow never happens, and 
gcc (for one) is known to take advantage of this.

Also, it would be nice to cleanup the whitespace in this function while 
you're fixing it;  at the moment it's showing me a mixture of tabs and 
spaces.
History
Date User Action Args
2009-01-13 21:56:37mark.dickinsonsetrecipients: + mark.dickinson, pitrou
2009-01-13 21:56:37mark.dickinsonsetmessageid: <1231883797.56.0.848554709303.issue4935@psf.upfronthosting.co.za>
2009-01-13 21:55:37mark.dickinsonlinkissue4935 messages
2009-01-13 21:55:36mark.dickinsoncreate