Author pitrou
Recipients ebfe, gps, gregory.p.smith, pitrou, vstinner
Date 2009-01-06.17:42:27
SpamBayes Score 0.0493678
Marked as misclassified No
Message-id <1231263748.42.0.709815016498.issue4751@psf.upfronthosting.co.za>
In-reply-to
Content
The patch looks fine to me, apart from one point: the return value of
PyThread_allocate_lock() should be checked for NULL, and the error
either propagated or cleared.

(I'd also suggest lowering HASHLIB_GIL_MINSIZE to 2048 or 4196)

Gregory, what's your take?
History
Date User Action Args
2009-01-06 17:42:28pitrousetrecipients: + pitrou, gregory.p.smith, vstinner, gps, ebfe
2009-01-06 17:42:28pitrousetmessageid: <1231263748.42.0.709815016498.issue4751@psf.upfronthosting.co.za>
2009-01-06 17:42:27pitroulinkissue4751 messages
2009-01-06 17:42:27pitroucreate