Message79119
- The things_to_do static variable should be declared as "volatile": it
is read by the main loop without any lock.
(by the way, could you rename it to something like "pendingcalls_to_do"?)
- in the old Py_MakePendingCalls function, the "#ifdef WITH_THREAD" part
is not useful now.
- the "XXX" comments should probably be rewritten.
A note to people concerned by performance: the additional lock is used
only when there is an actual pending call to process. The main loop only
regularly checks the "things_to_do static" volatile static variable, and
the patch does not change this. |
|
Date |
User |
Action |
Args |
2009-01-05 10:29:10 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, kristjan.jonsson, christian.heimes |
2009-01-05 10:29:09 | amaury.forgeotdarc | set | messageid: <1231151349.73.0.606035790931.issue4293@psf.upfronthosting.co.za> |
2009-01-05 10:29:08 | amaury.forgeotdarc | link | issue4293 messages |
2009-01-05 10:29:06 | amaury.forgeotdarc | create | |
|