Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, christian.heimes, kristjan.jonsson
Date 2009-01-05.10:29:05
SpamBayes Score 0.0380046
Marked as misclassified No
Message-id <1231151349.73.0.606035790931.issue4293@psf.upfronthosting.co.za>
In-reply-to
Content
- The things_to_do static variable should be declared as "volatile": it
is read by the main loop without any lock.
(by the way, could you rename it to something like "pendingcalls_to_do"?)

- in the old Py_MakePendingCalls function, the "#ifdef WITH_THREAD" part
is not useful now. 

- the "XXX" comments should probably be rewritten.

A note to people concerned by performance: the additional lock is used
only when there is an actual pending call to process. The main loop only
regularly checks the "things_to_do static" volatile static variable, and
the patch does not change this.
History
Date User Action Args
2009-01-05 10:29:10amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, kristjan.jonsson, christian.heimes
2009-01-05 10:29:09amaury.forgeotdarcsetmessageid: <1231151349.73.0.606035790931.issue4293@psf.upfronthosting.co.za>
2009-01-05 10:29:08amaury.forgeotdarclinkissue4293 messages
2009-01-05 10:29:06amaury.forgeotdarccreate