Author vstinner
Recipients barry, beazley, brotchie, vstinner
Date 2009-01-02.01:21:57
SpamBayes Score 2.12385e-06
Marked as misclassified No
Message-id <1230859320.42.0.0950895992934.issue4768@psf.upfronthosting.co.za>
In-reply-to
Content
> I think the library function base64.b64encode() should return 
> a string, not bytes.

Yes, in the email module, the payload is an unicode string, not a 
bytes string. We have to be able to concatenate headers 
(eg. "Content-Type: image/fish\nMIME-Version: 
1.0\nContent-Transfer-Encoding: base64\n") and encoded data 
(eg. "R0lGO").

Attached patch implements this fix: encode_base64() returns str (and 
not bytes). The patchs fixes the unit tests and adds a new regression 
test for MIMEImage.as_string().
History
Date User Action Args
2009-01-02 01:22:00vstinnersetrecipients: + vstinner, barry, beazley, brotchie
2009-01-02 01:22:00vstinnersetmessageid: <1230859320.42.0.0950895992934.issue4768@psf.upfronthosting.co.za>
2009-01-02 01:21:59vstinnerlinkissue4768 messages
2009-01-02 01:21:57vstinnercreate