Author ggenellina
Recipients faw, ggenellina, koen
Date 2008-12-27.05:33:11
SpamBayes Score 2.26049e-06
Marked as misclassified No
Message-id <1230356000.33.0.540504907798.issue4710@psf.upfronthosting.co.za>
In-reply-to
Content
Your usage of os.sep is incorrect, both when reading and writing 
directories.

Zip files are (more-or-less) platform independent. The specification 
*requires* forward slashes in paths [1], and the zipfile module 
already writes them that way. Checking for os.sep is wrong - at least 
on Windows. 

I've never encountered malformed entries of that kind (like "directory
\" instead of "directory/") but if you want to suport such beasts, 
check for "/" *and* os.sep explicitely.

[1] See APPNOTE.TXT (there is a link near the top of zipfile.py)
History
Date User Action Args
2008-12-27 05:33:24ggenellinasetrecipients: + ggenellina, koen, faw
2008-12-27 05:33:20ggenellinasetmessageid: <1230356000.33.0.540504907798.issue4710@psf.upfronthosting.co.za>
2008-12-27 05:33:16ggenellinalinkissue4710 messages
2008-12-27 05:33:13ggenellinacreate