Author mark.dickinson
Recipients fredrikj, haypo, loewis, mark.dickinson, rhettinger, terry.reedy
Date 2008-12-12.18:10:44
SpamBayes Score 4.27911e-09
Marked as misclassified No
Message-id <1229105446.49.0.825337214884.issue3439@psf.upfronthosting.co.za>
In-reply-to
Content
> I choosed to use consistent result type. But now I would prefer int :-) I see 
> that PyInt_FromSize_t() returns a long if the value doesn't fit in an int. So 
> it's correct.

Cool.  I think int is better, simply because the result is almost always going to fit 
into an int in practice, and because calculations with ints are faster.

> I'm paranoid

Yeah, me too.  I removed the check, but also changed the assert to check that
Py_SIZE is nonzero.

> Can you fix these two issues (use PyInt_FromSize_t and remove the if)?

Done.
History
Date User Action Args
2008-12-12 18:10:46mark.dickinsonsetrecipients: + mark.dickinson, loewis, rhettinger, terry.reedy, haypo, fredrikj
2008-12-12 18:10:46mark.dickinsonsetmessageid: <1229105446.49.0.825337214884.issue3439@psf.upfronthosting.co.za>
2008-12-12 18:10:45mark.dickinsonlinkissue3439 messages
2008-12-12 18:10:45mark.dickinsoncreate