Author mark.dickinson
Recipients fredrikj, haypo, loewis, mark.dickinson, rhettinger, terry.reedy
Date 2008-12-11.21:12:12
SpamBayes Score 2.57341e-09
Marked as misclassified No
Message-id <1229029935.49.0.170376167392.issue3439@psf.upfronthosting.co.za>
In-reply-to
Content
Victor,

Thanks for the updated patch.

I think you need to do a PyErr_Clear after the 'return PyLong_FromSize_t' line.

To be safe, you should probably check the exception type first, and either 
do a PyErr_Clear and continue if it's an OverflowError, or just return 
NULL if it's some other exception.  It's true that _PyLong_NumBits can't 
raise anything other than OverflowError at the moment, but you never know 
when that might change. :)

I'm also getting a 'malformed table' warning when building the 
documentation.
History
Date User Action Args
2008-12-11 21:12:16mark.dickinsonsetrecipients: + mark.dickinson, loewis, rhettinger, terry.reedy, haypo, fredrikj
2008-12-11 21:12:15mark.dickinsonsetmessageid: <1229029935.49.0.170376167392.issue3439@psf.upfronthosting.co.za>
2008-12-11 21:12:14mark.dickinsonlinkissue3439 messages
2008-12-11 21:12:13mark.dickinsoncreate