Author jjlee
Recipients andresriancho, facundobatista, jimjjewett, jjlee, jtonsing, orsenthil, pitrou
Date 2008-12-02.22:26:05
SpamBayes Score 5.2307e-05
Marked as misclassified No
Message-id <1228256766.89.0.026943807876.issue1401@psf.upfronthosting.co.za>
In-reply-to
Content
I think this was actually not a bug, and the fix should not have been
applied.  I guess this comment is just "for the record", as the fix is
probably cruft that can't be removed now, since people will have started
relying on it.

The only way that the Content-Length header could be in req.headers in
the first place is if the user had explicitly requested that it be added
(urllib2 adds that header to .unredirected_hdrs, but not to .headers). 
The user can no doubt provoke all kinds of other errors by adding random
HTTP headers -- what makes this particular one special?  .add_header()
has always been a "you need to know what you're doing, or you'll break
stuff" interface, and it's not really possible to "fix" that (at least
not without changing the meaning of .add_header()).
History
Date User Action Args
2008-12-02 22:26:07jjleesetrecipients: + jjlee, facundobatista, jimjjewett, orsenthil, pitrou, andresriancho, jtonsing
2008-12-02 22:26:06jjleesetmessageid: <1228256766.89.0.026943807876.issue1401@psf.upfronthosting.co.za>
2008-12-02 22:26:06jjleelinkissue1401 messages
2008-12-02 22:26:05jjleecreate