Author mark.dickinson
Recipients christian.heimes, gregory.p.smith, mark.dickinson, vstinner
Date 2008-11-06.09:01:54
SpamBayes Score 1.33869e-07
Marked as misclassified No
Message-id <1225962116.13.0.309106210293.issue4258@psf.upfronthosting.co.za>
In-reply-to
Content
> Yes, it uses base 2**15 but it's not the correct conversion to base 
> 2**15. You convert each PyLong digit to base 2**15 but not the whole 
> number.

I don't understand:  yes, each base 2**30 digit is converted to a pair 
of base 2**15 digits, and if necessary (i.e., if the top 15 bits of the 
most significant base 2**30 digit are zero) the size is adjusted.  How 
is this not converting the whole number?

> As a result, the format is different than the current mashal version.

Can you give an example of an integer n such that marshal.dumps(n) gives 
you different results with and without the patch?  As far as I can tell, 
I'm getting the same marshal results both with the unpatched version and 
with the patch applied.
History
Date User Action Args
2008-11-06 09:01:56mark.dickinsonsetrecipients: + mark.dickinson, gregory.p.smith, vstinner, christian.heimes
2008-11-06 09:01:56mark.dickinsonsetmessageid: <1225962116.13.0.309106210293.issue4258@psf.upfronthosting.co.za>
2008-11-06 09:01:55mark.dickinsonlinkissue4258 messages
2008-11-06 09:01:54mark.dickinsoncreate