Message 75207 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	jjlee
Recipients	BitTorment, facundobatista, jjlee, orsenthil, zathras
Date	2008-10-25.12:40:07
SpamBayes Score	0.0004917935
Marked as misclassified	No
Message-id	<1224938411.75.0.309650185823.issue2756@psf.upfronthosting.co.za>
In-reply-to

Content
I agree there is a bug here: clearly the methods on the Request class are inconsistent with AbstractHTTPHandler.do_open() . I think Facundo's patch is good, though it needs a test. The general principle when fixing earlier bugs has been that the .add_*header() methods override default headers, though there are some reasonable violations this where the implementation relies on specific headers being sent -- e.g. "Connection: close".

I agree there is a bug here: clearly the methods on the Request class
are inconsistent with AbstractHTTPHandler.do_open() .  I think Facundo's
patch is good, though it needs a test.

The general principle when fixing earlier bugs has been that the
.add_*header() methods override default headers, though there are some
reasonable violations this where the implementation relies on specific
headers being sent -- e.g. "Connection: close".

History
Date	User	Action	Args
2008-10-25 12:40:11	jjlee	set	recipients: + jjlee, facundobatista, orsenthil, zathras, BitTorment
2008-10-25 12:40:11	jjlee	set	messageid: <1224938411.75.0.309650185823.issue2756@psf.upfronthosting.co.za>
2008-10-25 12:40:08	jjlee	link	issue2756 messages
2008-10-25 12:40:07	jjlee	create