Message74962
Martin,
compilation indeed breaks if sysconf is available but _SC_CLK_TCK is
not. My Unix-foo is not sufficient to confidently say that this is
impossible, so my suggestion is to add defined(_SC_CLK_TCK) to the
condition of this #ifdef branch. For what it's worth, this also appears
to be the way Perl does it (perl.c, lines 384-385):
#if defined(HAS_SYSCONF) && defined(_SC_CLK_TCK) && !defined(__BEOS__)
PL_clocktick = sysconf(_SC_CLK_TCK);
In the other case you mention, where neither sysconf nor HZ are
available, the old default of 60 could be used instead. A noisy error
appears safer to me to avoid future similar bugs, but I see that this is
a bad idea for Python 2.5.x.
I'll prepare a modified patch. |
|
Date |
User |
Action |
Args |
2008-10-18 23:32:05 | maltehelmert | set | recipients:
+ maltehelmert, gvanrossum, loewis, gregory.p.smith, belopolsky, pitrou, ocean-city, christian.heimes, LambertDW, rbp |
2008-10-18 23:32:04 | maltehelmert | set | messageid: <1224372724.9.0.65364236813.issue1040026@psf.upfronthosting.co.za> |
2008-10-18 23:31:09 | maltehelmert | link | issue1040026 messages |
2008-10-18 23:31:08 | maltehelmert | create | |
|